netdev - Re: [PATCH iwl-next v1 6/7] ixgbe: replace EEE enable flag with state enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb9f2295-0f1d-48a3-ab53-3d51c2930f94@lunn.ch>
Date: Tue, 13 Jan 2026 15:15:41 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH iwl-next v1 6/7] ixgbe: replace EEE enable flag with
 state enum

> OK, so you mean it's redundant? There's no need to explicitly state that
> EEE needs to be disabled when it i not capable of beeing still on due 
> to unsupported link conditions?
> Probably i would need to check how E610 behaves in such scenario.

It would depend on what your firmware is doing, but if it is
implemented correctly, there should not be any need to change the
configuration. ethtool_keee->eee_active should indicate the status of
the negotiation. If you are in a link mode which does not support EEE,
so it is turned off in the MAC, set it to false. supported_eee,
advertising_eee lp_advertised should not care about the current link
mode or the value of eee_active.

And you probably want to check for how phylink and phylib handle this,
since they are the most used implementation and so the reference.

      Andrew