netdev - Re: [PATCH net-next 2/2] selftests: net: improve error handling in passive TFO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWZVFRrhENOk_l6z@desktop.y-koj.net>
Date: Tue, 13 Jan 2026 23:22:13 +0900
From: Yohei Kojima <yk@...oj.net>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Simon Horman <horms@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] selftests: net: improve error handling in
 passive TFO test

On Tue, Jan 13, 2026 at 10:46:10AM +0100, Markus Elfring wrote:
> > This commit improves the error handling in passive TFO test to check the
> > return value from … and  to fail if read() failed.
> 
> Would any developers and system testers like to care more also for data output failures?
> https://elixir.bootlin.com/linux/v6.19-rc4/source/tools/testing/selftests/net/tfo.c#L86-L88
> https://cwe.mitre.org/data/definitions/252.html

That's right. Although we can assume that fprintf() usually succeeds,
it worth checking its return value as tfo_passive.sh relies on the
content of the output.

I posted the v2 series adding fprintf() error handling here:
https://lore.kernel.org/netdev/cover.1768312014.git.yk@y-koj.net/

Thank you,
Yohei

> 
> Regards,
> Markus