netdev - Re: [PATCH net-next v2 2/3] dpll: add dpll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb8e4434-7a34-4580-a830-a9e79c049c94@redhat.com>
Date: Tue, 13 Jan 2026 19:38:43 +0100
From: Ivan Vecera <ivecera@...hat.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, netdev@...r.kernel.org
Cc: Donald Hunter <donald.hunter@...il.com>, Jakub Kicinski
 <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Prathosh Satish <Prathosh.Satish@...rochip.com>, Petr Oros
 <poros@...hat.com>, linux-kernel@...r.kernel.org,
 Michal Schmidt <mschmidt@...hat.com>
Subject: Re: [PATCH net-next v2 2/3] dpll: add dpll_device op to set working
 mode

On 1/13/26 6:47 PM, Vadim Fedorenko wrote:
> On 13/01/2026 12:16, Ivan Vecera wrote:
>> Currently, userspace can retrieve the DPLL working mode but cannot
>> configure it. This prevents changing the device operation, such as
>> switching from manual to automatic mode and vice versa.
>>
>> Add a new callback .mode_set() to struct dpll_device_ops. Extend
>> the netlink policy and device-set command handling to process
>> the DPLL_A_MODE attribute.  Update the netlink YAML specification
>> to include the mode attribute in the device-set operation.
>>
>> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
>> ---
>> v2:
>> * fixed bitmap size in dpll_mode_set()
> 
> [...]
> 
>> +static int
>> +dpll_mode_set(struct dpll_device *dpll, struct nlattr *a,
>> +          struct netlink_ext_ack *extack)
>> +{
>> +    const struct dpll_device_ops *ops = dpll_device_ops(dpll);
>> +    enum dpll_mode mode = nla_get_u32(a), old_mode;
>> +    DECLARE_BITMAP(modes, DPLL_MODE_MAX + 1) = { 0 };
> 
> this one breaks reverse xmas tree order.

oops, my bad :-(

> with this fixed:
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>

will fix... thanks for pointing this out.

Ivan