netdev - Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260114191645.03ed8d67@kernel.org>
Date: Wed, 14 Jan 2026 19:16:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tao Wang <tao03.wang@...izon.auto>
Cc: <alexandre.torgue@...s.st.com>, <andrew+netdev@...n.ch>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
 <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <maxime.chevallier@...tlin.com>, <mcoquelin.stm32@...il.com>,
 <netdev@...r.kernel.org>, <pabeni@...hat.com>, <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after
 resume

On Wed, 14 Jan 2026 19:00:31 +0800 Tao Wang wrote:
> To solve the issue, set last_segment to false in stmmac_free_tx_buffer:
> tx_q->tx_skbuff_dma[i].last_segment = false.  Do not use the last_segment
>  default value and set last_segment to false in stmmac_tso_xmit. This
> will prevent similar issues from occurring in the future.
> 
> Fixes: c2837423cb54 ("net: stmmac: Rework TX Coalesce logic")
> 
> changelog:
> v1 -> v2:
> 	- Modify commit message, del empty line, add fixed commit
> 	 information.
> 
> Signed-off-by: Tao Wang <tao03.wang@...izon.auto>

When you repost to address Russell's feedback in the commit
message please:
 - follow the recommended format (changelog placement and no empty
   lines between Fixes and SoB):
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
 - do not send new version in reply to the old one, start a new thread
-- 
pw-bot: cr