netdev - Re: Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260115070853.116260-1-tao03.wang@horizon.auto>
Date: Thu, 15 Jan 2026 15:08:53 +0800
From: Tao Wang <tao03.wang@...izon.auto>
To: <linux@...linux.org.uk>
CC: <alexandre.torgue@...s.st.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <maxime.chevallier@...tlin.com>,
	<mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<tao03.wang@...izon.auto>
Subject: Re: Re: [PATCH net v2] net: stmmac: fix transmit queue timed out after resume

> While I agree with the change for stmmac_tso_xmit(), please explain why
> the change in stmmac_free_tx_buffer() is necessary.
>
> It seems to me that if this is missing in stmmac_free_tx_buffer(), the
> driver should have more problems than just TSO.

The change in stmmac_free_tx_buffer() is intended to be generic for all
users of last_segment, not only for the TSO path.

So far, I have not observed any issues with stmmac_xmit() or
stmmac_xdp_xmit_xdpf(), but this change ensures consistent and correct
handling of last_segment across all relevant transmit paths.

Thanks
Tao Wang