netdev - Re: [PATCH net 3/4] can: raw: instantly reject disabled CAN frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260115-cordial-conscious-warthog-aa8079-mkl@pengutronix.de>
Date: Thu, 15 Jan 2026 09:59:58 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Oliver Hartkopp <socketcan@...tkopp.net>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	linux-can@...r.kernel.org, kernel@...gutronix.de, Arnd Bergmann <arnd@...db.de>, 
	Vincent Mailhol <mailhol@...nel.org>
Subject: Re: [PATCH net 3/4] can: raw: instantly reject disabled CAN frames

On 15.01.2026 08:55:33, Oliver Hartkopp wrote:
> Hello Marc,
>
> On 14.01.26 11:45, Marc Kleine-Budde wrote:
> > From: Oliver Hartkopp <socketcan@...tkopp.net>
>
> > @@ -944,6 +945,10 @@ static int raw_sendmsg(struct socket *sock, struct msghdr *msg, size_t size)
> >   	if (!dev)
> >   		return -ENXIO;
> > +	/* no sending on a CAN device in read-only mode */
> > +	if (can_cap_enabled(dev, CAN_CAP_RO))
> > +		return -EACCES;
> > +
> >   	skb = sock_alloc_send_skb(sk, size + sizeof(struct can_skb_priv),
> >   				  msg->msg_flags & MSG_DONTWAIT, &err);
> >   	if (!skb)
>
> At midnight the AI review from the netdev patchwork correctly identified a
> problem with the above code:
>
> https://netdev-ai.bots.linux.dev/ai-review.html?id=fb201338-eed0-488f-bb32-5240af254cf4

Is the review sent exclusively in a direct email or available in a
mailing list?

> Can you please change it in your tree and send an updated PR?

yes

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)