netdev - Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62ad756f-f507-4030-9b01-aeb3ad3f89ea@molgen.mpg.de>
Date: Fri, 16 Jan 2026 18:48:44 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Sreedevi Joshi <sreedevi.joshi@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix flow rule delete
 failure due to invalid validation

[Cc: Remove Ahmed as address bounces]

Am 16.01.26 um 18:39 schrieb Paul Menzel:

> Dear Sreedevi,
> 
> 
> Thank you for your patch.
> 
> Am 13.01.26 um 19:01 schrieb Sreedevi Joshi:
>> When deleting a flow rule using "ethtool -N <dev> delete <location>",
>> idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
>> though ethtool doesn't populate this field for delete operations. The
>> uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or
>> RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate
>> rule deletions. Remove the unnecessary sideband action enable check and
>> ring_cookie validation during delete operations since action validation
>> is not required when removing existing rules.
>>
>> Fixes: ada3e24b84a0 ("idpf: add flow steering support")
>> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@...el.com>
>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>> ---
>>   drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/ 
>> net/ethernet/intel/idpf/idpf_ethtool.c
>> index 2efa3c08aba5..49cefb973f4d 100644
>> --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
>> +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
>> @@ -307,9 +307,6 @@ static int idpf_del_flow_steer(struct net_device 
>> *netdev,
>>       vport_config = vport->adapter->vport_config[np->vport_idx];
>>       user_config = &vport_config->user_config;
>> -    if (!idpf_sideband_action_ena(vport, fsp))
>> -        return -EOPNOTSUPP;
>> -
>>       rule = kzalloc(struct_size(rule, rule_info, 1), GFP_KERNEL);
>>       if (!rule)
>>           return -ENOMEM;
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul