netdev - Re: [PATCH 1/2] net: phy: realtek: add RTL8224 pair swap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bc038f3-4048-4008-84c8-4f0303f0db93@kernel.org>
Date: Sat, 17 Jan 2026 11:47:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Damien Dejean <dam.dejean@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: phy: realtek: add RTL8224 pair swap support

On 16/01/2026 18:39, Damien Dejean wrote:
> The RTL8224 has a register to configure a pair swap (from ABCD order to
> DCBA) providing PCB designers more flexbility when wiring the chip. The
> swap parameter has to be set correctly for each of the 4 ports before
> the chip can detect a link.
> 
> After a reset, this register is (unfortunately) left in a random state,
> thus it has to be initialized. On most of the devices the bootloader
> does it once for all and we can rely on the value set, on some other it
> is not and the kernel has to do it.
> 
> The MDI pair swap can be set in the device tree using the property
> realtek,mdi-pair-swap. The property is set to "off" to disable the pair
> swap, "on" to enable it, or "keep"/unset to keep the current
> configuration.
> 
> Signed-off-by: Damien Dejean <dam.dejean@...il.com>
> ---
>  .../bindings/net/realtek,rtl82xx.yaml         | 13 ++++

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

Best regards,
Krzysztof