netdev - Re: [PATCH 2/2] net: phy: realtek: add RTL8224 polarity swap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30324c2a-8dc9-46e3-b220-4d6cd06d2480@kernel.org>
Date: Sat, 17 Jan 2026 11:47:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Damien Dejean <dam.dejean@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: phy: realtek: add RTL8224 polarity swap support

On 16/01/2026 18:39, Damien Dejean wrote:
> The RTL8224 has a register to configure the polarity of every pair of
> each port. It provides device designers more flexbility when wiring the
> chip.
> 
> Unfortunately, the register is left in an unknown state after a reset.
> Thus on devices where the bootloader don't initialize it, the driver has
> to do it to detect and use a link.
> 
> The MDI polarity swap can be set in the device tree using the property
> realtek,mdi-polarity-swap. The u32 value is a bitfield where bit[0..3]
> control the polarity of pairs A...D.
> 
> Signed-off-by: Damien Dejean <dam.dejean@...il.com>
> ---
>  .../bindings/net/realtek,rtl82xx.yaml         |  7 +++++
>  drivers/net/phy/realtek/realtek_main.c        | 29 +++++++++++++++++++
>  2 files changed, 36 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> index 2d04d90f8b97..4abcc5cfaf5f 100644
> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -67,6 +67,13 @@ properties:
>        - off
>      default: keep
>  
> +  realtek,mdi-polarity-swap:
> +    description:
> +      A bitmap to describe pair polarity swap. Bit 0 to swap polarity of pair A,
> +      bit 1 to swap polarity of pair B, bit 2 to swap polarity of pair C and bit
> +      3 to swap polarity of pair D.
> +    $ref: /schemas/types.yaml#/definitions/uint32

Same problem.

Best regards,
Krzysztof