netdev - Re: [PATCH 1/2] net: phy: realtek: add RTL8224 pair swap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0EE90427-54F7-40BF-81FF-B7DA76544338@gmail.com>
Date: Mon, 19 Jan 2026 18:54:21 +0100
From: Damien Dejean <dam.dejean@...il.com>
To: Andrew Lunn <andrew@...n.ch>,
 krzk@...nel.org
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: phy: realtek: add RTL8224 pair swap support

Hi Andrew, Krzysztof,

Thanks for your feedbacks.

On 16 Jan 2026, at 19:10, Andrew Lunn <andrew@...n.ch> wrote:
> 
> Does the PHY support auto MDI-X, where it figures out a working
> combination at link up time? That allows you to use crossed or not
> crossed cables.

It does support auto MDI-X, it’s possible to read the status of it after a cable is connected. However this is different from the swap mechanism I’m introducing here.

> 
> Anyway, the DT property you are adding seems to be the same as
> marvell,mdi-cfg-order. See commit:
> 
> 1432965bf5ce ("dt-bindings: net: marvell,aquantia: add property to override MDI_CFG")
> 
>> +  realtek,mdi-pair-swap:
> 
> Maybe call this realtek,mdi-cfg-order and use the same binding?

It looks like the same mechanism, thanks for the reference. The aquantia implementation looks more straightforward, let me rework the patchs to have a similar implementation.

> Changes to DT bindings should be in a patch of its own.

Thanks for the notice, I missed that when I ran checkpatch.

Damien