netdev - Re: [net-next,v2,2/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260119163410.1147227-1-kuba@kernel.org>
Date: Mon, 19 Jan 2026 08:34:10 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: linusw@...nel.org
Cc: Jakub Kicinski <kuba@...nel.org>,
	olteanv@...il.com,
	pabeni@...hat.com,
	davem@...emloft.net,
	woojung.huh@...rochip.com,
	andrew@...n.ch,
	UNGLinuxDriver@...rochip.com,
	netdev@...r.kernel.org,
	edumazet@...gle.com
Subject: Re: [net-next,v2,2/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support

This commit removes support for KSZ8864 and KSZ8795 chip variants from
the ks8995 driver, since those variants are better supported by the
dedicated Microchip KSZ driver.

> diff --git a/drivers/net/dsa/ks8995.c b/drivers/net/dsa/ks8995.c
> index ff01097601ec..5ad62fa4e52c 100644
> --- a/drivers/net/dsa/ks8995.c
> +++ b/drivers/net/dsa/ks8995.c

[ ... ]

> @@ -804,8 +700,8 @@ static int ks8995_probe(struct spi_device *spi)
>  	if (err)
>  		return err;
>
> -	dev_info(&spi->dev, "%s device found, Chip ID:%x, Revision:%x\n",
> -		 ks->chip->name, ks->chip->chip_id, ks->revision_id);
> +	dev_info(&spi->dev, "KS8955MA device found, Chip ID:%x, Revision:%x\n",
                             ^^^^^^^

Should this be "KS8995MA" instead of "KS8955MA"? The chip name appears to
have a typo - the driver is for KS8995 (as in the file name, module
description, and all other references), but the dev_info prints "KS8955MA"
with transposed digits.

> +		 KS8995_CHIP_ID, ks->revision_id);
-- 
pw-bot: cr