netdev - Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance for PFs on same chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e645d5e7-2f5f-4f38-b8e5-056f0cba46ce@kernel.org>
Date: Thu, 22 Jan 2026 08:42:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>
Cc: Donald Hunter <donald.hunter@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Jonathan Corbet <corbet@....net>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, Mark Bloch <mbloch@...dia.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-rdma@...r.kernel.org,
 Gal Pressman <gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>,
 Carolina Jubran <cjubran@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>,
 Jiri Pirko <jiri@...dia.com>, Randy Dunlap <rdunlap@...radead.org>,
 Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance
 for PFs on same chip

On 20/01/2026 08:57, Tariq Toukan wrote:
> +
> +static const struct devlink_ops mlx5_shd_ops = {
> +};
> +
> +int mlx5_shd_init(struct mlx5_core_dev *dev)
> +{
> +	u8 *vpd_data __free(kfree) = NULL;

So you just ignore people's comments. What is the point of review then?

Please respond to review and do not send the same buggy or wrong code.

Best regards,
Krzysztof