netdev - Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance for PFs on same chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77465165fc53b31b13ca7ba6c25137622847872a.camel@nvidia.com>
Date: Thu, 22 Jan 2026 11:13:29 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "krzk@...nel.org" <krzk@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: "corbet@....net" <corbet@....net>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "donald.hunter@...il.com"
	<donald.hunter@...il.com>, "leon@...nel.org" <leon@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"rdunlap@...radead.org" <rdunlap@...radead.org>, Jiri Pirko
	<jiri@...dia.com>, Carolina Jubran <cjubran@...dia.com>, "horms@...nel.org"
	<horms@...nel.org>, Mark Bloch <mbloch@...dia.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, Saeed Mahameed <saeedm@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Gal Pressman
	<gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net-next V5 10/15] net/mlx5: Add a shared devlink instance
 for PFs on same chip

On Thu, 2026-01-22 at 08:42 +0100, Krzysztof Kozlowski wrote:
> On 20/01/2026 08:57, Tariq Toukan wrote:
> > +
> > +static const struct devlink_ops mlx5_shd_ops = {
> > +};
> > +
> > +int mlx5_shd_init(struct mlx5_core_dev *dev)
> > +{
> > +	u8 *vpd_data __free(kfree) = NULL;
> 
> So you just ignore people's comments. What is the point of review
> then?
> 
> Please respond to review and do not send the same buggy or wrong
> code.

Apologies, it was an oversight. I thought Jiri fixed this part and
didn't think to look at this particular bit. I even added a (false)
statement in the cover letter about this.

Will __really__ fix in the next version.

Cosmin.