netdev - Re: [PATCH net-next] virtio_net: Increase RSS max key size to match NETDEV_RSS_KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260122075206.504ec591@kernel.org>
Date: Thu, 22 Jan 2026 07:52:06 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Srujana Challa <schalla@...vell.com>, Willem de Bruijn
 <willemb@...gle.com>
Cc: <netdev@...r.kernel.org>, <virtualization@...ts.linux.dev>,
 <pabeni@...hat.com>, <mst@...hat.com>, <jasowang@...hat.com>,
 <xuanzhuo@...ux.alibaba.com>, <eperezma@...hat.com>,
 <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <ndabilpuram@...vell.com>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next] virtio_net: Increase RSS max key size to match
 NETDEV_RSS_KEY_LEN

On Thu, 22 Jan 2026 14:45:27 +0530 Srujana Challa wrote:
> Increase VIRTIO_NET_RSS_MAX_KEY_SIZE from 40 to 52 bytes to align with
> the kernel's standard RSS key length defined by NETDEV_RSS_KEY_LEN.

I've been meaning to bump NETDEV_RSS_KEY_LEN to 128 or some such.
Most modern drivers can't use netdev_rss_key_fill() either because
core generates a tiny key. And the devices support hashing over two
layers of IPv6 for tunnels.

Willem, WDYT? Is there a reason to keep the core key small?
Or deprecate netdev_rss_key_fill()?

> The virtio specification requires devices to support at least 40 bytes
> for the RSS key size. However, devices may support larger key sizes
> up to 52 bytes (as reported by the device's rss_max_key_size config
> field). This change allows such devices to work properly.
> Previously, devices reporting rss_max_key_size > 40 would fail with
> an error during initialization.
> 
> The driver already handles variable key sizes dynamically through
> vi->rss_key_size, so increasing the maximum limit is safe and
> maintains backward compatibility with devices that support smaller
> key sizes.

> -#define VIRTIO_NET_RSS_MAX_KEY_SIZE     40
> +#define VIRTIO_NET_RSS_MAX_KEY_SIZE     52