netdev - Re: [PATCH v2 net-next] ipvlan: remove ipvlan_ht_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXPWtCFRgNZuO1K4@horms.kernel.org>
Date: Fri, 23 Jan 2026 20:14:44 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH v2 net-next] ipvlan: remove ipvlan_ht_addr_lookup()

On Thu, Jan 22, 2026 at 04:50:49PM +0000, Eric Dumazet wrote:
> ipvlan_ht_addr_lookup() is called four times and not inlined.
> 
> Split it to ipvlan_ht_addr_lookup6() and ipvlan_ht_addr_lookup4()
> and rework ipvlan_addr_lookup() to call these helpers once,
> so that they are (auto)inlined.
> 
> After this change, ipvlan_addr_lookup() is faster, and we save
> 350 bytes of text on x86_64.
> 
> $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new
> add/remove: 0/2 grow/shrink: 1/0 up/down: 123/-473 (-350)
> Function                                     old     new   delta
> ipvlan_addr_lookup                           467     590    +123
> __pfx_ipvlan_ht_addr_lookup                   16       -     -16
> ipvlan_ht_addr_lookup                        457       -    -457
> Total: Before=22571833, After=22571483, chg -0.00%
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Mahesh Bandewar <maheshb@...gle.com>
> ---
> v2: guard ipvlan_ht_addr_lookup6() with CONFIG_IPV6 (kernel test robot)
> v1: https://lore.kernel.org/netdev/20260121215728.560645-1-edumazet@google.com/
>  drivers/net/ipvlan/ipvlan_core.c | 55 ++++++++++++++++++++------------
>  1 file changed, 34 insertions(+), 21 deletions(-)

Reviewed-by: Simon Horman <horms@...nel.org>