netdev - Re: [PATCH net-next] net: usb: replace unnecessary get_link functions with usbnet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a1e7173-2520-4b53-aed3-e3186503927e@lunn.ch>
Date: Sat, 24 Jan 2026 19:51:07 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Peter Korsgaard <peter@...sgaard.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Max Schulze <max.schulze@...ine.de>,
	Krzysztof Hałasa <khalasa@...p.pl>
Subject: Re: [PATCH net-next] net: usb: replace unnecessary get_link
 functions with usbnet_get_link

On Sat, Jan 24, 2026 at 12:22:06AM -0800, Ethan Nelson-Moore wrote:
> usbnet_get_link calls mii_link_ok if the device has a MII defined in
> its usbnet struct and no check_connect function defined there. This is
> true of these drivers, so their custom get_link functions which call
> mii_link_ok are useless. Remove them in favor of usbnet_get_link.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew