netdev - Re: [PATCH net-next] net: usb: replace unnecessary get_link functions with usbnet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cy2ym52f.fsf@dell.be.48ers.dk>
Date: Sun, 25 Jan 2026 10:09:44 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org,  linux-usb@...r.kernel.org,  Andrew Lunn
 <andrew+netdev@...n.ch>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Oleksij Rempel <o.rempel@...gutronix.de>,  Max
 Schulze <max.schulze@...ine.de>,  Krzysztof Hałasa
 <khalasa@...p.pl>
Subject: Re: [PATCH net-next] net: usb: replace unnecessary get_link
 functions with usbnet_get_link

>>>>> "Ethan" == Ethan Nelson-Moore <enelsonmoore@...il.com> writes:

 > usbnet_get_link calls mii_link_ok if the device has a MII defined in
 > its usbnet struct and no check_connect function defined there. This is
 > true of these drivers, so their custom get_link functions which call
 > mii_link_ok are useless. Remove them in favor of usbnet_get_link.

 > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>

Reviewed-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard