netdev - Re: [PATCH net-next] net: usb: remove unnecessary get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXSZpWJnfuzpDX-C@smile.fi.intel.com>
Date: Sat, 24 Jan 2026 12:06:29 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Peter Korsgaard <peter@...sgaard.com>,
	Petko Manolov <petkan@...leusys.com>,
	Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
	Oliver Neukum <oneukum@...e.com>,
	Krzysztof Hałasa <khalasa@...p.pl>,
	Deepanshu Kartikey <kartikey406@...il.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Max Schulze <max.schulze@...ine.de>,
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Kees Cook <kees@...nel.org>, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH net-next] net: usb: remove unnecessary get_drvinfo code
 and driver versions

On Sat, Jan 24, 2026 at 01:23:26AM -0800, Ethan Nelson-Moore wrote:
> Many USB network drivers define get_drvinfo functions which add no
> value over usbnet_get_drvinfo, only setting the driver name and
> version. usbnet_get_drvinfo automatically sets the driver name, and
> separate driver versions are now frowned upon in the kernel. Remove all
> driver versions and replace these get_drvinfo functions with references
> to usbnet_get_drvinfo where possible. Where that is not possible,
> remove unnecessary code to set the driver name. Also remove two
> unnecessary initializations from aqc111_get_drvinfo, an inaccurate
> comment in pegasus.c, and an unused macro in catc.c.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

...

> static void catc_get_drvinfo(struct net_device *dev,

>  {
>  	struct catc *catc = netdev_priv(dev);
>  	strscpy(info->driver, driver_name, sizeof(info->driver));

Side note: and we usually require blank line after the definition block.
On top, strscpy() in such cases can be improved to use 2-arguments variant,
as it adds a check for the destination to be an array.

> -	strscpy(info->version, DRIVER_VERSION, sizeof(info->version));
>  	usb_make_path(catc->usbdev, info->bus_info, sizeof(info->bus_info));
>  }

...

> static void rtl8152_get_drvinfo(struct net_device *netdev,

>  	struct r8152 *tp = netdev_priv(netdev);
>  
>  	strscpy(info->driver, MODULENAME, sizeof(info->driver));

Ditto.

> -	strscpy(info->version, DRIVER_VERSION, sizeof(info->version));
>  	usb_make_path(tp->udev, info->bus_info, sizeof(info->bus_info));
>  	if (!IS_ERR_OR_NULL(tp->rtl_fw.fw))
>  		strscpy(info->fw_version, tp->rtl_fw.version,

Seems the same, and so on...

-- 
With Best Regards,
Andy Shevchenko