netdev - Re: [PATCH net-next] net: usb: sr9700: replace magic numbers with register bit macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldhns3x7.fsf@dell.be.48ers.dk>
Date: Sat, 24 Jan 2026 11:25:40 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org,  linux-usb@...r.kernel.org,  Andrew Lunn
 <andrew+netdev@...n.ch>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] net: usb: sr9700: replace magic numbers with
 register bit macros

>>>>> "Ethan" == Ethan Nelson-Moore <enelsonmoore@...il.com> writes:

 > The first byte of the Rx frame is a copy of the Rx status register, so
 > 0x40 corresponds to RSR_MF (meaning the frame is multicast). Replace
 > 0x40 with RSR_MF for clarity. (All other bits of the RSR indicate
 > errors. The fact that the driver ignores these errors will be fixed by
 > a later patch.)

 > The first byte of the status URB is a copy of the NSR, so 0x40
 > corresponds to NSR_LINKST. Replace 0x40 with NSR_LINKST for clarity.

 > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>

I don't know the device, but sounds sensible.

Reviewed-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard