netdev - Re: [PATCH v2 net-next] net: usb: remove unnecessary get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXTHhI710LK1EsTG@smile.fi.intel.com>
Date: Sat, 24 Jan 2026 15:22:12 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Peter Korsgaard <peter@...sgaard.com>,
	Petko Manolov <petkan@...leusys.com>,
	Steve Glendinning <steve.glendinning@...well.net>,
	UNGLinuxDriver@...rochip.com,
	Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
	Oliver Neukum <oneukum@...e.com>,
	Krzysztof Hałasa <khalasa@...p.pl>,
	Deepanshu Kartikey <kartikey406@...il.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Max Schulze <max.schulze@...ine.de>,
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Kees Cook <kees@...nel.org>, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH v2 net-next] net: usb: remove unnecessary get_drvinfo
 code and driver versions

On Sat, Jan 24, 2026 at 02:19:45AM -0800, Ethan Nelson-Moore wrote:
> Many USB network drivers define get_drvinfo functions which add no
> value over usbnet_get_drvinfo, only setting the driver name and
> version. usbnet_get_drvinfo automatically sets the driver name, and
> separate driver versions are now frowned upon in the kernel. Remove all
> driver versions and replace these get_drvinfo functions with references
> to usbnet_get_drvinfo where possible. Where that is not possible,
> remove unnecessary code to set the driver name. Also remove two
> unnecessary initializations from aqc111_get_drvinfo, an inaccurate
> comment in pegasus.c, and an unused macro in catc.c.

There are three problems with this version:
1) you haven't taken my tag, why?
2) there is no changelog to understand what's going on;
3) the v2 was sent too quickly (usually should be 24h+ between the versions).

-- 
With Best Regards,
Andy Shevchenko