netdev - Re: [PATCH net-next] net: usb: introduce usbnet_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d17a810-9e74-4ef1-8fa7-3267a8678b40@lunn.ch>
Date: Sat, 24 Jan 2026 19:48:40 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Peter Korsgaard <peter@...sgaard.com>,
	Steve Glendinning <steve.glendinning@...well.net>,
	Oliver Neukum <oneukum@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Max Schulze <max.schulze@...ine.de>,
	Krzysztof Hałasa <khalasa@...p.pl>
Subject: Re: [PATCH net-next] net: usb: introduce usbnet_mii_ioctl helper
 function

>  static int smsc75xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
>  {
> -	struct usbnet *dev = netdev_priv(netdev);
> -
>  	if (!netif_running(netdev))
>  		return -EINVAL;
>  
> -	return generic_mii_ioctl(&dev->mii, if_mii(rq), cmd, NULL);
> +	return usbnet_mii_ioctl(netdev, rq, cmd);
>  }

You are doing the same as phy_do_ioctl(), but for the old mii
code. However, we also have phy_do_ioctl_running(). It might make
sense to add usbnet_mii_ioctl_running()?

	Andrew