netdev - Re: [PATCH net-next] net: usb: introduce usbnet_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADkSEUig7Pp66nDx5ch+txDfNcbLj1wRUbC3n4a4pBuc9mBb4Q@mail.gmail.com>
Date: Sat, 24 Jan 2026 18:53:57 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Peter Korsgaard <peter@...sgaard.com>, Steve Glendinning <steve.glendinning@...well.net>, 
	Oliver Neukum <oneukum@...e.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Oleksij Rempel <o.rempel@...gutronix.de>, Max Schulze <max.schulze@...ine.de>, 
	Krzysztof Hałasa <khalasa@...p.pl>
Subject: Re: [PATCH net-next] net: usb: introduce usbnet_mii_ioctl helper function

On Sat, Jan 24, 2026 at 10:48 AM Andrew Lunn <andrew@...n.ch> wrote:
> You are doing the same as phy_do_ioctl(), but for the old mii
> code. However, we also have phy_do_ioctl_running(). It might make
> sense to add usbnet_mii_ioctl_running()?

Hi, Andrew,

It makes sense in principle, but after applying my patch to smsc95xx
to use phy_do_ioctl_running, smsc75xx is the only driver that would
use such a function, so it would add complexity rather than removing
it.

Ethan