netdev - Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADkSEUiwQTq=175VZ7Trm4Mf2o7_ckcAkPouoawC5s4oumdcdQ@mail.gmail.com>
Date: Sun, 25 Jan 2026 13:41:28 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>, netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-pci@...r.kernel.org, linux-mips@...r.kernel.org, 
	linux-s390@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	Jon Mason <jdmason@...zu.us>, Jonathan Corbet <corbet@....net>, 
	Linas Vepstas <linasvepstas@...il.com>, Mahesh J Salgaonkar <mahesh@...ux.ibm.com>, 
	"Oliver O'Halloran" <oohall@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Madhavan Srinivasan <maddy@...ux.ibm.com>, 
	Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, 
	Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
	Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, 
	Sven Schnelle <svens@...ux.ibm.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Danilo Krummrich <dakr@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Andrew Morton <akpm@...ux-foundation.org>, 
	Martin Kepplinger-Novaković <martink@...teo.de>, 
	Pavel Machek <pavel@....cz>, MD Danish Anwar <danishanwar@...com>, 
	Mengyuan Lou <mengyuanlou@...-swift.com>, Pablo Neira Ayuso <pablo@...filter.org>, 
	Huacai Chen <chenhuacai@...nel.org>, "Theodore Ts'o" <tytso@....edu>, Takashi Iwai <tiwai@...e.de>, 
	Eric Biggers <ebiggers@...gle.com>, Madadi Vineeth Reddy <vineethr@...ux.ibm.com>, 
	Ard Biesheuvel <ardb@...nel.org>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Frederic Barrat <fbarrat@...ux.ibm.com>, Andrew Donnellan <ajd@...ux.ibm.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Lorenzo Bianconi <lorenzo@...nel.org>, Dong Yibo <dong100@...se.com>, 
	Lukas Bulwahn <lukas.bulwahn@...hat.com>, Vivian Wang <wangruikang@...as.ac.cn>, 
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused driver

On Sun, Jan 25, 2026 at 10:11 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
> What is the value in removing the IDs?
>
> The values can never be reused for new hardware, so removal doesn't
> make room for anything in the future.  Unlike the removal of driver
> code, removing the IDs doesn't reduce complexity or improve
> readability or maintainability.

Understood. I'll send an updated patch which retains the device IDs.