Message-ID: <20260125181125.GA209392@bhelgaas>
Date: Sun, 25 Jan 2026 12:11:25 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>,
	netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-mips@...r.kernel.org,
	linux-s390@...r.kernel.org, rust-for-linux@...r.kernel.org,
	Jon Mason <jdmason@...zu.us>, Jonathan Corbet <corbet@....net>,
	Linas Vepstas <linasvepstas@...il.com>,
	Mahesh J Salgaonkar <mahesh@...ux.ibm.com>,
	Oliver O'Halloran <oohall@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Danilo Krummrich <dakr@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Martin Kepplinger-Novaković <martink@...teo.de>,
	Pavel Machek <pavel@....cz>, MD Danish Anwar <danishanwar@...com>,
	Mengyuan Lou <mengyuanlou@...-swift.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Huacai Chen <chenhuacai@...nel.org>, Theodore Ts'o <tytso@....edu>,
	Takashi Iwai <tiwai@...e.de>, Eric Biggers <ebiggers@...gle.com>,
	Madadi Vineeth Reddy <vineethr@...ux.ibm.com>,
	Ard Biesheuvel <ardb@...nel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Frederic Barrat <fbarrat@...ux.ibm.com>,
	Andrew Donnellan <ajd@...ux.ibm.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Dong Yibo <dong100@...se.com>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Vivian Wang <wangruikang@...as.ac.cn>,
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH net-next] net: ethernet: neterion: s2io: remove unused
 driver

On Sat, Jan 24, 2026 at 03:32:17PM -0800, Ethan Nelson-Moore wrote:
> On Fri, Jan 23, 2026 at 11:25 PM Christophe Leroy (CS GROUP)
> <chleroy@...nel.org> wrote:
> > Yes and that's exactly the reason why removing unused IDs will be a problem.
> >
> > Let's take an exemple: some patch adds PCI_DEVICE_ID_ARECA_1682 after
> > PCI_DEVICE_ID_ARECA_1681 in pci_ids.h in the mainline. That patch needs
> > to be backported and it conflicts with PCI_VENDOR_ID_S2IO which is not
> > anymore in the mainline but is still in stable.
> 
> Hi, Christophe,
> 
> I understand your reasoning now. Thanks for clarifying. In my opinion,
> changes to pci_ids.h don't happen often enough for that to be a
> problem. Unused IDs have been removed from it before.

What is the value in removing the IDs?

The values can never be reused for new hardware, so removal doesn't
make room for anything in the future.  Unlike the removal of driver
code, removing the IDs doesn't reduce complexity or improve
readability or maintainability.

Powered by blists - more mailing lists