netdev - Re: [PATCH net-next] net: usb: switch to two-argument strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXc89lDpfHQFVX-7@smile.fi.intel.com>
Date: Mon, 26 Jan 2026 12:07:50 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Thangaraj Samynathan <Thangaraj.S@...rochip.com>,
	Rengarajan Sundararajan <Rengarajan.S@...rochip.com>,
	UNGLinuxDriver@...rochip.com, Petko Manolov <petkan@...leusys.com>,
	Oliver Neukum <oneukum@...e.com>,
	Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
	Krzysztof Hałasa <khalasa@...p.pl>,
	Deepanshu Kartikey <kartikey406@...il.com>,
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	Foster Snowhill <forst@....gy>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Kees Cook <kees@...nel.org>, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH net-next] net: usb: switch to two-argument strscpy

On Sun, Jan 25, 2026 at 07:50:15PM -0800, Ethan Nelson-Moore wrote:
> All instances of strscpy in the USB network drivers use the size of the
> destination. If given only two arguments, strscpy will automatically
> use the size of the destination. Make the code more concise by
> switching to the two-argument form of strscpy.
> 
> Also add a blank line after a variable declaration in catc.c to adhere
> to kernel code style, since the surrounding code is being touched.

It should go after your patch that drops some of the strscpy():s.
Hence make a v3 as a series of two patches.

Code wise this LGTM, thanks for doing this.

-- 
With Best Regards,
Andy Shevchenko