netdev - Re: [PATCH net-next] net: alacritech: Use u64_stats_t with u64_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK9xfvQ275f+PPht8mM6K49mUq-T9D-4UUxUkTncM4tRw@mail.gmail.com>
Date: Mon, 26 Jan 2026 11:11:09 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: David Yang <mmyangfl@...il.com>, netdev@...r.kernel.org, 
	Lino Sanfilippo <LinoSanfilippo@....de>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: alacritech: Use u64_stats_t with
 u64_stats_sync properly

On Mon, Jan 26, 2026 at 12:23 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 23 Jan 2026 02:51:07 +0800 David Yang wrote:
> > On 64bit arches, struct u64_stats_sync is empty and provides no help
> > against load/store tearing. Convert to u64_stats_t to ensure atomic
> > operations.
>
> Eric, could you comment if this matters? I expect David may send a
> non-trivial number of these, I want to make sure we're making good
> use of everyone's time here. 64b accesses are not torn on 64b arches,
> and never used for control flow.

I  added u64_stats_add()/u64_stats_inc() back in 2019, and never bothered
sending dozens of patches.

Presumably compilers could be really dumb back then, I am not sure
this is still the case today.