netdev - Re: [v3,net-next,04/15] net/nebula-matrix: add channel layer implementation and the corresponding hw interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260127181503.1439691-1-horms@kernel.org>
Date: Tue, 27 Jan 2026 18:15:03 +0000
From: Simon Horman <horms@...nel.org>
To: illusion.wang@...ula-matrix.com
Cc: Simon Horman <horms@...nel.org>,
	dimon.zhao@...ula-matrix.com,
	john.fastabend@...il.com,
	sam.chen@...ula-matrix.com,
	sdf@...ichev.me,
	lukas.bulwahn@...hat.com,
	kuba@...nel.org,
	vadim.fedorenko@...ux.dev,
	edumazet@...gle.com,
	hawk@...nel.org,
	bpf@...r.kernel.org,
	corbet@....net,
	pabeni@...hat.com,
	lorenzo@...nel.org,
	alvin.wang@...ula-matrix.com,
	andrew+netdev@...n.ch,
	netdev@...r.kernel.org,
	daniel@...earbox.net,
	linux-doc@...r.kernel.org,
	ast@...nel.org,
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [v3,net-next,04/15] net/nebula-matrix: add channel layer implementation and the corresponding hw interfaces

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net/nebula-matrix: add intr resource implementation

This patch adds MSI-X interrupt vector management for the Nebula Matrix
network driver, including dynamic allocation of interrupt vectors,
mapping table management, and interrupt enable/disable support.

> diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_resource.h b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_resource.h
> index f6fd151141d5..b8653e0039d7 100644
> --- a/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_resource.h
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_resource.h

[ ... ]

> @@ -10,12 +10,20 @@
>  #include "nbl_core.h"
>  #include "nbl_hw.h"
>
> +struct nbl_resource_mgt;
> +
>  #define NBL_RES_MGT_TO_COMMON(res_mgt)		((res_mgt)->common)
>  #define NBL_RES_MGT_TO_COMMON_OPS(res_mgt)	(&((res_mgt)->common_ops))
>  #define NBL_RES_MGT_TO_DEV(res_mgt) \
>  	NBL_COMMON_TO_DEV(NBL_RES_MGT_TO_COMMON(res_mgt))
>  #define NBL_RES_MGT_TO_DMA_DEV(res_mgt)		\
>  	NBL_COMMON_TO_DMA_DEV(NBL_RES_MGT_TO_COMMON(res_mgt))
> +#define NBL_RES_MGT_TO_INTR_MGT(res_mgt)	((res_mgt)->intr_mgt)
> +#define NBL_RES_MGT_TO_QUEUE_MGT(res_mgt)	((res_mgt)->queue_mgt)
> +#define NBL_RES_MGT_TO_TXRX_MGT(res_mgt)	((res_mgt)->txrx_mgt)
> +#define NBL_RES_MGT_TO_VSI_MGT(res_mgt)		((res_mgt)->vsi_mgt)
> +#define NBL_RES_MGT_TO_INTR_MGT(res_mgt)	((res_mgt)->intr_mgt)
                                                ^^^^^^^^^^^^^^^^^^^^^^^^
Is NBL_RES_MGT_TO_INTR_MGT intentionally defined twice here? It appears
on both lines with identical definitions, which will generate a compiler
warning for macro redefinition.

> +#define NBL_RES_MGT_TO_PROD_OPS(res_mgt)	((res_mgt)->product_ops)

[ ... ]