netdev - Re: [PATCH net-next] net: usb: sr9700: remove code to drive nonexistent multicast filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADkSEUhUtR8SuQALcBNVf5qoRTrBx8HkL+PmNiM3QQDwRM5D+w@mail.gmail.com>
Date: Mon, 26 Jan 2026 20:17:59 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Peter Korsgaard <peter@...sgaard.com>
Subject: Re: [PATCH net-next] net: usb: sr9700: remove code to drive
 nonexistent multicast filter

On Mon, Jan 26, 2026 at 7:26 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > +     else if (netdev->flags & IFF_ALLMULTI || netdev_mc_count(netdev) > 0)
>
> nit: netdev_mc_empty()

Hi, Jakub,

Thanks for noticing - I don't know how I missed that, given that the
original code was using it.

I have adjusted this patch to use netdev_mc_empty. It is now part of a
series of sr9700 patches I'm still working on, and the multicast
filter removal is separate from the other changes.

Ethan