netdev - Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a8f6225-09b5-4320-bfe5-4248b4a99844@lunn.ch>
Date: Wed, 28 Jan 2026 14:04:49 +0100
From: Andrew Lunn <andrew@...n.ch>
To: javen <javen_xu@...lsil.com.cn>
Cc: hkallweit1@...il.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, horms@...nel.org, kuba@...nel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	nic_swsd@...ltek.com, pabeni@...hat.com
Subject: Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

> RTL8116af is a multi-function device. fun0 is a BMC virtual driver and fun1 is
> the nic driver. The BMC virtual driver(fun0) is used for power management,
> while fun1 provides the actual network functionality.

This is the sort of thing which should be in patch 0/X, because at the
moment, this patch series makes no sense to me. You need to explain
the big picture, especially when doing something so odd.

What does this BMC virtual driver do? Is it providing an NCSI like
device? Should it have a real driver at some point in the future, more
than this stub?

> >>   r816e: add a fake driver r816e for RTL8116af

Please could you explain the naming. The device is RTL8116af, yet the
files are r816e.c ?

	Andrew