netdev - Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a13d635-7a22-4de6-a4bb-1ae4351b114c@gmail.com>
Date: Wed, 28 Jan 2026 20:08:12 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: javen <javen_xu@...lsil.com.cn>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, kuba@...nel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, nic_swsd@...ltek.com, pabeni@...hat.com
Subject: Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

On 1/28/2026 7:53 AM, javen wrote:
>> On 1/27/2026 12:34 PM, javen wrote:
> 
>>> From: Javen Xu <javen_xu@...lsil.com.cn>
> 
>>>
> 
>>> This series patch add a fake driver r816e to ensure the kernel could 
> 
>>> set the correct power state for #fun through r816e driver when suspending.
> 
>>>
> 
>>
> 
>> I think a better approach would be to contribute to adding phylink/sfp support
> 
>> to r8169, so that the SFP NIC versions (incl. RTL8116AF) can be properly
> 
>> supported. This would have to include making the SFP I2C bus accessible by
> 
>> the kernel (instead of firmware only).
> 
>>
> 
> 
> 
> RTL8116af is a multi-function device. fun0 is a BMC virtual driver and fun1 is
> 
> the nic driver. The BMC virtual driver(fun0) is used for power management,
> 
> while fun1 provides the actual network functionality.
> 
> 
If only purpose of this dummy driver is to bring the device to D3hot during system
suspend, then this may be a question to the PCI subsystem maintainer(s).
PCI devices are instantiated by the PCI core, just that in case of the device here
no driver gets attached. Still PCI core applies a default suspend handling to each
device.