netdev - Re: [PATCH net-next v3] net: usb: remove unnecessary get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260127185856.7ff5d1a2@kernel.org>
Date: Tue, 27 Jan 2026 18:58:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Peter Korsgaard
 <peter@...sgaard.com>, Petko Manolov <petkan@...leusys.com>, Steve
 Glendinning <steve.glendinning@...well.net>, UNGLinuxDriver@...rochip.com,
 Nikita Zhandarovich <n.zhandarovich@...tech.ru>, Oliver Neukum
 <oneukum@...e.com>, Krzysztof Hałasa <khalasa@...p.pl>,
 Deepanshu Kartikey <kartikey406@...il.com>, Oleksij Rempel
 <o.rempel@...gutronix.de>, Max Schulze <max.schulze@...ine.de>, Thomas
 Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...nel.org>, "Gustavo A. R.
 Silva" <gustavoars@...nel.org>, Kees Cook <kees@...nel.org>, Eric Biggers
 <ebiggers@...gle.com>
Subject: Re: [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo
 code and driver versions

On Mon, 26 Jan 2026 22:04:38 -0800 Ethan Nelson-Moore wrote:
> Many USB network drivers define get_drvinfo functions which add no
> value over usbnet_get_drvinfo, only setting the driver name and
> version. usbnet_get_drvinfo automatically sets the driver name, and
> separate driver versions are now frowned upon in the kernel. Remove all
> driver versions and replace these get_drvinfo functions with references
> to usbnet_get_drvinfo where possible. Where that is not possible,
> remove unnecessary code to set the driver name. Also remove two
> unnecessary initializations from aqc111_get_drvinfo, an inaccurate
> comment in pegasus.c, and an unused macro in catc.c.

I slightly lost track of the conversations on your patches so forgive
a possibly obvious statement :) - but this did not apply cleanly to
net-next at the time of posting. So it needs a respin.
-- 
pw-bot: cr