netdev - Re: [PATCH net-next v03 3/4] hinic3: Use array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXu9yZBySHREdqoY@devvm20253.cco0.facebook.com>
Date: Thu, 29 Jan 2026 12:06:33 -0800
From: Joe Damato <joe@...a.to>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, luosifu <luosifu@...wei.com>,
	Xin Guo <guoxin09@...wei.com>, Zhou Shuai <zhoushuai28@...wei.com>,
	Wu Like <wulike1@...wei.com>, Shi Jing <shijing34@...wei.com>,
	Luo Yang <luoyang82@...artners.com>
Subject: Re: [PATCH net-next v03 3/4] hinic3: Use array_size instead of
 multiplying

On Thu, Jan 29, 2026 at 12:01:10PM +0800, Fan Gong wrote:
> Since commit 17fcb3dc12bb ("hinic3: module initialization and tx/rx logic")
> use "size * sizeof(u64)" in hinic3_feature_nego.
> Use array_size instead of multiplying can make it clearer.
> 
> Link: https://lore.kernel.org/netdev/20250911123120.GG30363@horms.kernel.org/
> Co-developed-by: Zhu Yikai <zhuyikai1@...artners.com>
> Signed-off-by: Zhu Yikai <zhuyikai1@...artners.com>
> Signed-off-by: Fan Gong <gongfan1@...wei.com>
> ---
>  drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

create_cmdq_wq in hinic3_cmdq.c has a memcpy that could probably benefit from
array_size, but I'm not sure.

For this change though:

Reviewed-by: Joe Damato <joe@...a.to>