netdev - Re: [PATCH net-next v03 1/4] hinic3: Fix code Style(remove empty lines between error handling)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXu/SDa0Z+w0v5zv@devvm20253.cco0.facebook.com>
Date: Thu, 29 Jan 2026 12:12:56 -0800
From: Joe Damato <joe@...a.to>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, luosifu <luosifu@...wei.com>,
	Xin Guo <guoxin09@...wei.com>, Zhou Shuai <zhoushuai28@...wei.com>,
	Wu Like <wulike1@...wei.com>, Shi Jing <shijing34@...wei.com>,
	Luo Yang <luoyang82@...artners.com>
Subject: Re: [PATCH net-next v03 1/4] hinic3: Fix code Style(remove empty
 lines between error handling)

On Thu, Jan 29, 2026 at 12:01:08PM +0800, Fan Gong wrote:
> According to previous review comment, fix code style of removing empty

Hm, I'm wondering if maybe the subject or commit message could be reworded a
little bit?

Maybe something simpler like:

  Subject: [PATCH net-next v3 1/4] hinic3: Remove empty lines
  
  Make error handling paths more idiomatic by removing empty lines.
  
  Link: https://lore.kernel.org/netdev/20250902180937.4c8d9eb3@kernel.org/
  Co-developed-by: ...
  Signed-off-by: ...

Maybe Simon has a better suggestion.