netdev - Re: [v5,2/3] dt-bindings: net: nxp,s32-dwmac: Use the GPR syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129051035.375905-1-kuba@kernel.org>
Date: Wed, 28 Jan 2026 21:10:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: dan.carpenter@...aro.org
Cc: Jakub Kicinski <kuba@...nel.org>,
	jan.petrous@....nxp.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	pabeni@...hat.com,
	mcoquelin.stm32@...il.com,
	imx@...ts.linux.dev,
	chester62515@...il.com,
	mbrugger@...e.com,
	netdev@...r.kernel.org,
	s32@....com,
	conor+dt@...nel.org,
	andrew+netdev@...n.ch,
	robh@...nel.org,
	kernel@...gutronix.de,
	linux-stm32@...md-mailman.stormreply.com,
	shawnguo@...nel.org,
	linux-kernel@...r.kernel.org,
	ghennadi.procopciuc@....nxp.com,
	linaro-s32@...aro.org,
	linux-arm-kernel@...ts.infradead.org,
	alexandre.torgue@...s.st.com,
	krzk+dt@...nel.org,
	devicetree@...r.kernel.org,
	festevam@...il.com,
	s.hauer@...gutronix.de
Subject: Re: [v5,2/3] dt-bindings: net: nxp,s32-dwmac: Use the GPR syscon

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
dt-bindings: net: nxp,s32-dwmac: Use the GPR syscon

This commit adds the nxp,phy-sel property to the S32 DWMAC binding,
allowing access to the GMAC_0_CTRL_STS register via a syscon interface
instead of the previous ad-hoc direct register mapping.

> diff --git a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
> index 2b8b74c5feec..65633b10e49e 100644
> --- a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml

[ ... ]

> +  nxp,phy-sel:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: phandle to the GPR syscon node
> +          - description: offset of PHY selection register
> +    description:
> +      This phandle points to the GMAC_0_CTRL_STS register which controls the
> +      GMAC_0 configuration options.  The register lets you select the PHY
> +      interface and the PHY mode.  It also controls if the FTM_0 or FTM_1
> +      FlexTimer Modules connect to GMAC_O.
                                       ^^^^^^

Should this be GMAC_0 (with a zero) instead of GMAC_O (with a letter O)?
The rest of the description uses GMAC_0_CTRL_STS and GMAC_0 consistently.
-- 
pw-bot: cr