netdev - Re: [net-next] amd-xgbe: add support rx alignment and length errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129051111.376038-1-kuba@kernel.org>
Date: Wed, 28 Jan 2026 21:11:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Raju.Rangoju@....com
Cc: Jakub Kicinski <kuba@...nel.org>,
	netdev@...r.kernel.org,
	andrew+netdev@...n.ch,
	edumazet@...gle.com,
	pabeni@...hat.com,
	davem@...emloft.net,
	Shyam-sundar.S-k@....com
Subject: Re: [net-next] amd-xgbe: add support rx alignment and length errors

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
amd-xgbe: add support rx alignment and length errors

This patch adds support for reading rx alignment errors from the hardware
MMC registers and updates the rtnl_link_stats64 structure.

> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index b5a60a048896..ebc5fe8324ea 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -1838,6 +1838,8 @@ static void xgbe_get_stats64(struct net_device *netdev,
>  	s->rx_length_errors = pstats->rxlengtherror;
>  	s->rx_crc_errors = pstats->rxcrcerror;
>  	s->rx_over_errors = pstats->rxfifooverflow;
> +	s->rx_frame_errors = pstats->rxalignmenterror;
> +	s->rx_length_errors = pstats->rxlengtherror;

Is this line a duplicate? The assignment to s->rx_length_errors already
appears three lines above. Perhaps this was intended to be a different
assignment?
-- 
pw-bot: cr