netdev - RE: [Intel-wired-lan] [PATCH net v3 1/2] i40e: drop udp_tunnel_get_rx_info() call from i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241DC627D84F32FCF7FB8448B9EA@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Thu, 29 Jan 2026 07:07:51 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "mheib@...hat.com" <mheib@...hat.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"aduyck@...antis.com" <aduyck@...antis.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
	Paul Menzel <pmenzel@...gen.mpg.de>
Subject: RE: [Intel-wired-lan] [PATCH net v3 1/2] i40e: drop
 udp_tunnel_get_rx_info() call from i40e_open()

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of mheib@...hat.com
> Sent: 29 December 2025 01:10
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; davem@...emloft.net; aduyck@...antis.com; kuba@...nel.org; netdev@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>; pabeni@...hat.com; Mohammad Heib <mheib@...hat.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Paul Menzel <pmenzel@...gen.mpg.de>
> Subject: [Intel-wired-lan] [PATCH net v3 1/2] i40e: drop udp_tunnel_get_rx_info() call from i40e_open()
>
> From: Mohammad Heib <mheib@...hat.com>
>
> The i40e driver calls udp_tunnel_get_rx_info() during i40e_open().
> This is redundant because UDP tunnel RX offload state is preserved across device down/up cycles. The udp_tunnel core handles synchronization automatically when required.
>
> Furthermore, recent changes in the udp_tunnel infrastructure require querying RX info while holding the udp_tunnel lock. Calling it directly from the ndo_open path violates this requirement, triggering the following lockdep warning:
>
>  Call Trace:
>   <TASK>
>   ? __udp_tunnel_nic_assert_locked+0x39/0x40 [udp_tunnel]
>   i40e_open+0x135/0x14f [i40e]
>   __dev_open+0x121/0x2e0
>   __dev_change_flags+0x227/0x270
>   dev_change_flags+0x3d/0xb0
>   devinet_ioctl+0x56f/0x860
>   sock_do_ioctl+0x7b/0x130
>   __x64_sys_ioctl+0x91/0xd0
>   do_syscall_64+0x90/0x170
>   ...
>   </TASK>
>
> Remove the redundant and unsafe call to udp_tunnel_get_rx_info() from
> i40e_open() resolve the locking violation.
>
> Fixes: 1ead7501094c ("udp_tunnel: remove rtnl_lock dependency")
> Signed-off-by: Mohammad Heib <mheib@...hat.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 1 -
> 1 file changed, 1 deletion(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)