netdev - RE: [Intel-wired-lan] [PATCH net v3 2/2] ice: drop udp_tunnel_get_rx_info() call from ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62416C0EC736D64EB075B3F58B9EA@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Thu, 29 Jan 2026 07:07:55 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "mheib@...hat.com" <mheib@...hat.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"aduyck@...antis.com" <aduyck@...antis.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net v3 2/2] ice: drop
 udp_tunnel_get_rx_info() call from ndo_open()

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of mheib@...hat.com
> Sent: 29 December 2025 01:10
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; davem@...emloft.net; aduyck@...antis.com; kuba@...nel.org; netdev@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>; pabeni@...hat.com; Mohammad Heib <mheib@...hat.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> Subject: [Intel-wired-lan] [PATCH net v3 2/2] ice: drop udp_tunnel_get_rx_info() call from ndo_open()
>
> From: Mohammad Heib <mheib@...hat.com>
>
> The ice driver calls udp_tunnel_get_rx_info() during ice_open_internal().
> This is redundant because UDP tunnel RX offload state is preserved across device down/up cycles. The udp_tunnel core handles synchronization automatically when required.
>
> Furthermore, recent changes in the udp_tunnel infrastructure require querying RX info while holding the udp_tunnel lock. Calling it directly from the ndo_open path violates this requirement, triggering the following lockdep warning:
>
> Call Trace:
>  <TASK>
>  ice_open_internal+0x253/0x350 [ice]
>  __udp_tunnel_nic_assert_locked+0x86/0xb0 [udp_tunnel]
>  __dev_open+0x2f5/0x880
>  __dev_change_flags+0x44c/0x660
>  netif_change_flags+0x80/0x160
>  devinet_ioctl+0xd21/0x15f0
>  inet_ioctl+0x311/0x350
>  sock_ioctl+0x114/0x220
>  __x64_sys_ioctl+0x131/0x1a0
>  ...
>  </TASK>
>
> Remove the redundant and unsafe call to udp_tunnel_get_rx_info() from
> ice_open_internal() to resolve the locking violation
>
> Fixes: 1ead7501094c ("udp_tunnel: remove rtnl_lock dependency")
> Signed-off-by: Mohammad Heib <mheib@...hat.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)