netdev - Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c19fdbaf-e179-4bbd-b51e-4de154233776@oracle.com>
Date: Fri, 30 Jan 2026 19:10:13 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Bhargava Chenna Marreddy <bhargava.marreddy@...adcom.com>
Cc: Vikas Gupta <vikas.gupta@...adcom.com>, rajashekar.hudumula@...adcom.com,
        netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] bng_en: fix misleading error message for generic
 firmware version



On 1/30/2026 6:36 PM, Bhargava Chenna Marreddy wrote:
>> On 1/30/2026 2:05 PM, Vikas Gupta wrote:
>>>>    drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>>>> index a987afebd64d..57db3caabcfb 100644
>>>> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>>>> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
>>>> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
>>>>                                 DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>>>>           if (rc) {
>>>>                   NL_SET_ERR_MSG_MOD(extack,
>>>> -                                  "Failed to set roce firmware version");
>>>> +                                  "Failed to set generic firmware version");
>>> Thanks for fixing. I believe instead of generic, "Failed to set
>>> firmware version"  is enough.
>> ACK. will send v2.
> Should this be a candidate for net with a Fixes tag?

I am open to either approach. It does not break functionality, but the 
current message can be misleading so I am happy to tag it for net if you 
think it’s appropriate.

> 
> Thanks,
> Bhargava Marreddy

Thanks,
Alok