[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6403ac87-38b7-4d68-919a-09a8394d6209@bootlin.com>
Date: Fri, 30 Jan 2026 14:38:32 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Romain Gantois <romain.gantois@...tlin.com>, davem@...emloft.net,
Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>, Heiner Kallweit <hkallweit1@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
thomas.petazzoni@...tlin.com, Christophe Leroy
<christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <vladimir.oltean@....com>,
Köry Maincent <kory.maincent@...tlin.com>,
Marek Behún <kabel@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>,
Nicolò Veronese <nicveronese@...il.com>,
Simon Horman <horms@...nel.org>, mwojtas@...omium.org,
Daniel Golle <daniel@...rotopia.org>,
Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next 09/13] net: phy: phy_port: Store information
about a MII port's occupancy
On 28/01/2026 17:08, Romain Gantois wrote:
> On Tuesday, 27 January 2026 14:41:57 CET Maxime Chevallier wrote:
>> MII phy_ports are not meant to be connected directly to a link partner.
>> They are meant to feed into some media converter devices, so far we only
>> support SFP modules for that.
>>
>> We have information about what MII they can handle, however we don't
>> store anything about whether they are currently connected to an SFP
>> module or not. As phy_port aims at listing the front-facing ports, let's
>> store an "occupied" bit to know whether or not a MII port is currently
>> front-facing (i.e. there's no module in the SFP cage), or occupied (i.e.
>> there's an SFP module).
>
> To me, "front-facing" refers to things like user ports on a switch versus CPU-
> facing ports, I don't find it intuitive to use it to qualify a port's state of
> being connected to an empty SFP cage.
>
> Why not use something like "vacant" or "empty" instead?
ah 'vacant' was the term I was looking for !
OK I'll update, I like that better :)
Maxime
>
> Thanks,
>
Powered by blists - more mailing lists