netdev - Re: [PATCH 05/19] printk: Add more context to suspend/resume functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87343n3ta8.fsf@jogness.linutronix.de>
Date: Fri, 30 Jan 2026 18:33:27 +0106
From: John Ogness <john.ogness@...utronix.de>
To: Marcos Paulo de Souza <mpdesouza@...e.com>, Richard Weinberger
 <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, Johannes
 Berg <johannes@...solutions.net>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jason Wessel <jason.wessel@...driver.com>,
 Daniel Thompson <danielt@...nel.org>, Douglas Anderson
 <dianders@...omium.org>, Petr Mladek <pmladek@...e.com>, Steven Rostedt
 <rostedt@...dmis.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, Jiri
 Slaby <jirislaby@...nel.org>, Breno Leitao <leitao@...ian.org>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Geert Uytterhoeven
 <geert@...ux-m68k.org>, Kees Cook <kees@...nel.org>, Tony Luck
 <tony.luck@...el.com>, "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael Ellerman
 <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Andreas Larsson
 <andreas@...sler.com>, Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Jacky Huang <ychuang3@...oton.com>,
 Shan-Chun Hung <schung@...oton.com>, Laurentiu Tudor
 <laurentiu.tudor@....com>
Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kgdb-bugreport@...ts.sourceforge.net, linux-serial@...r.kernel.org,
 netdev@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
 linux-hardening@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 sparclinux@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
 Marcos Paulo de Souza <mpdesouza@...e.com>
Subject: Re: [PATCH 05/19] printk: Add more context to suspend/resume functions

On 2025-12-27, Marcos Paulo de Souza <mpdesouza@...e.com> wrote:
> The new comments clarifies from where the functions are supposed to be
> called.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>
> ---
>  kernel/printk/printk.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 173c14e08afe..85a8b6521d9e 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2734,7 +2734,8 @@ MODULE_PARM_DESC(console_no_auto_verbose, "Disable console loglevel raise to hig
>  /**
>   * console_suspend_all - suspend the console subsystem
>   *
> - * This disables printk() while we go into suspend states
> + * This disables printk() while we go into suspend states. Called by the power
> + * management subsystem.

Since you are touching this comment, I would prefer to make it
technically accurate. It is not printk() that is disabled, it is console
printing that is disabled. Perhaps something like:

 * Block all console printing while the system goes into suspend state.
 * Called by the power management subsystem.

>   */
>  void console_suspend_all(void)
>  {
> @@ -2766,6 +2767,12 @@ void console_suspend_all(void)
>  	synchronize_srcu(&console_srcu);
>  }
>  
> +/**
> + * console_resume_all - resume the console subsystem
> + *
> + * This resumes printk() when the system is being restored. Called by the power
> + * management subsystem.

And something similar here:

 * Allow all console printing when the system resumes from suspend. Called by
 * the power management system.

> + */
>  void console_resume_all(void)
>  {
>  	struct console_flush_type ft;

John Ogness