netdev - Re: [PATCH net-next] net/iucv: clean up iucv kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260131164920.7e92896f@kernel.org>
Date: Sat, 31 Jan 2026 16:49:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: netdev@...r.kernel.org, Alexandra Winter <wintera@...ux.ibm.com>,
 Thorsten Winkler <twinkler@...ux.ibm.com>, linux-s390@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>
Subject: Re: [PATCH net-next] net/iucv: clean up iucv kernel-doc warnings

On Sat, 31 Jan 2026 16:01:04 -0800 Randy Dunlap wrote:
> On 1/31/26 1:11 PM, Jakub Kicinski wrote:
> > On Thu, 29 Jan 2026 21:47:59 -0800 Randy Dunlap wrote:  
> >>   * @path: address of iucv path structure
> >>   * @msg: address of iucv msg structure
> >>   * @flags: how the reply is sent (IUCV_IPRMDATA, IUCV_IPPRTY, IUCV_IPBUFLST)  
> > 
> > In general -- Could we possibly delete the duplicated kdocs in 
> > the header. As clearly shown by this patch it's double the work
> > and kernel-doc will be able to find the definition wherever it is.
> > Kernel coding guide recommends kdoc next to definition.  
> 
> Thanks. I'll check all of that.

You probably figured this out but reading back I realize that my
message wasn't very clear -- I meant that some of the functions
are both documented next to their fwd declaration in
include/net/iucv/iucv.h and the definition in net/iucv/iucv.c