netdev - Re: [PATCH net-next v1 2/7] net: ngbe: improve the reset flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ddc6f7d-ee6f-48a9-857f-a10448815675@lunn.ch>
Date: Tue, 3 Feb 2026 14:56:16 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Mengyuan Lou <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v1 2/7] net: ngbe: improve the reset flow

>  static void ngbe_reset(struct wx *wx)
>  {
> +	int err;
> +
> +	err = ngbe_reset_hw(wx);
> +	if (err != 0)

The != 0 is a bit odd. It looks like rest of the driver uses if (err)

> +		wx_err(wx, "Hardware Error: %d\n", err);

I also wounder if this should be fatal? Should ngbe_reset() be made an
int function so the error code can be returned?

	Andrew