netdev - RE: [PATCH v13 net-next 00/15] AccECN protocol case handling series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <AS8PR07MB797343EB84069170ACCFAE08A39BA@AS8PR07MB7973.eurprd07.prod.outlook.com>
Date: Tue, 3 Feb 2026 14:02:24 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Paolo Abeni <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "parav@...dia.com" <parav@...dia.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "corbet@....net"
	<corbet@....net>, "horms@...nel.org" <horms@...nel.org>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "kuniyu@...gle.com" <kuniyu@...gle.com>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "dave.taht@...il.com" <dave.taht@...il.com>,
	"jhs@...atatu.com" <jhs@...atatu.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "donald.hunter@...il.com"
	<donald.hunter@...il.com>, "ast@...erby.net" <ast@...erby.net>,
	"liuhangbin@...il.com" <liuhangbin@...il.com>, "shuah@...nel.org"
	<shuah@...nel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "ij@...nel.org" <ij@...nel.org>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
	<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
	<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
	<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
	"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
	<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com" <vidhi_goel@...le.com>
Subject: RE: [PATCH v13 net-next 00/15] AccECN protocol case handling series

> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com> 
> Sent: Tuesday, February 3, 2026 1:51 PM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>; edumazet@...gle.com; parav@...dia.com; linux-doc@...r.kernel.org; corbet@....net; horms@...nel.org; dsahern@...nel.org; kuniyu@...gle.com; bpf@...r.kernel.org; netdev@...r.kernel.org; dave.taht@...il.com; jhs@...atatu.com; kuba@...nel.org; stephen@...workplumber.org; xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net; andrew+netdev@...n.ch; donald.hunter@...il.com; ast@...erby.net; liuhangbin@...il.com; shuah@...nel.org; linux-kselftest@...r.kernel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com
> Subject: Re: [PATCH v13 net-next 00/15] AccECN protocol case handling series
> 
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> On 1/31/26 11:25 PM, chia-yu.chang@...ia-bell-labs.com wrote:
> > From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
> >
> > Hello,
> >
> > Plesae find the v13 AccECN case handling patch series, which covers 
> > several excpetional case handling of Accurate ECN spec (RFC9768), adds 
> > new identifiers to be used by CC modules, adds ecn_delta into 
> > rate_sample, and keeps the ACE counter for computation, etc.
> >
> > This patch series is part of the full AccECN patch series, which is at
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2FL4STeam%2Flinux-net-next%2Fcommits%2Fupstream_l4steam%2F&data
> > =05%7C02%7Cchia-yu.chang%40nokia-bell-labs.com%7C28d9664ae2ba4bc908b00
> > 8de6322d99f%7C5d4717519675428d917b70f44f9630b0%7C0%7C0%7C6390571985045
> > 13725%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
> > MCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
> > a=LE02CSf%2BwO3EhH844vnsvMN4ToH4FbvnmHNQH2GXKj4%3D&reserved=0
> 
> Beside the just shared feedback, the AI reported a bunch of other stuff that are not relevant:
> - fixes tags, IMHO not needed since the touched features were just partially implemented before
> - uapi breakage, already ruled out as irrelevant since the iproute bits are not there yet
> - pktdrill syntax, which is a little inconsistent but AFAICS correct.
> 
> I'm not sure about the BIT() macro usage in uAPI, which is already a thing in many uAPI exposed headers, but does not look correct. I guess it could be handled with a follow-up, if needed.
> 
> So the only feedback the could really require a new revision is WRT ECN flags handling on retransmission - and I'm not 110% it needs a new
> revision: please double check it.
> 
> Thanks,
> 
> Paolo

Hi Paolo,

Based on another email, if it is suggested to clarify that commit in the commit message then I can also include other listed issues.

And I would include fixes to packetdrill syntax and fixed to BIT() - which might have an issue if someone took only the header without BIT macro.

So, please let me know then I can submit v14 with all three changes, thanks.

Chia-Yu