netdev - Re: [PATCH v2] netfilter: amanda: fix RCU pointer typing for nf_nat_amanda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYIOXk55_DRFKCqo@strlen.de>
Date: Tue, 3 Feb 2026 16:03:58 +0100
From: Florian Westphal <fw@...len.de>
To: Sun Jian <sun.jian.kdev@...il.com>
Cc: Pablo Neira Ayuso <pablo@...filter.org>, Phil Sutter <phil@....cc>,
	Simon Horman <horms@...nel.org>, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] netfilter: amanda: fix RCU pointer typing for
 nf_nat_amanda_hook

Sun Jian <sun.jian.kdev@...il.com> wrote:
>  enum amanda_strings {
> @@ -98,7 +98,12 @@ static int amanda_help(struct sk_buff *skb,
>  	u_int16_t len;
>  	__be16 port;
>  	int ret = NF_ACCEPT;
> -	typeof(nf_nat_amanda_hook) nf_nat_amanda;
> +	unsigned int (*nf_nat_amanda)(struct sk_buff *skb,
> +				      enum ip_conntrack_info ctinfo,
> +				      unsigned int protoff,
> +				      unsigned int matchoff,
> +				      unsigned int matchlen,
> +				      struct nf_conntrack_expect *exp);

Why is that needed?