netdev - Re: [PATCH net 1/3] Revert "net: ag71xx: use devm for register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxU2N-zUJsgX8dFewAQk-xVdjHULDDGVy0zht8-qYd7_8Asow@mail.gmail.com>
Date: Tue, 3 Feb 2026 11:52:10 -0800
From: Rosen Penev <rosenp@...il.com>
To: Bartosz Golaszewski <brgl@...nel.org>
Cc: netdev@...r.kernel.org, Chris Snook <chris.snook@...il.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev"

On Tue, Feb 3, 2026 at 2:29 AM Bartosz Golaszewski <brgl@...nel.org> wrote:
>
> On Mon, Feb 2, 2026 at 10:48 PM Rosen Penev <rosenp@...il.com> wrote:
> >
> > This reverts commit cc20a4791641a1cbd1525695fac0d4725dd72509.
> >
> > register_netdev gets called after phylink_create which has no devm
> > equivalent. phylink_destroy must be called after unregister_netdev and
> > not before.
> >
> > Signed-off-by: Rosen Penev <rosenp@...il.com>
> > ---
>
> Can we just use devm_add_action_or_reset() with a callback calling
> phylink_destroy()? It will surely make error handling in probe easier
> and avoid mixing devm and non-managed APIs.
netdev seems to not like devm, at least according to
process/maintainer-netdev.rst

Anyway, I'm wary of custom devm_add_action_or_reset calls.
>
> Bart