netdev - Re: [PATCH net-next] tcp: use __skb_push() in __tcp_transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUAac_ZwS34OwLDDPHQUHyJ4Er9V2cdwyiP1Op9pW73cKA@mail.gmail.com>
Date: Tue, 3 Feb 2026 16:25:22 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: use __skb_push() in __tcp_transmit_skb()

On Mon, Feb 2, 2026 at 8:42 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> We trust MAX_TCP_HEADER to be large enough.
>
> Using the inlined version of skb_push() trades 8 bytes
> of text for better performance of TCP TX fast path.
>
> $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new
> add/remove: 0/0 grow/shrink: 1/0 up/down: 8/0 (8)
> Function                                     old     new   delta
> __tcp_transmit_skb                          3181    3189      +8
> Total: Before=24896035, After=24896043, chg +0.00%
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>