netdev - Re: [PATCH net-next] tcp: move tcp_rbtree_insert() to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUAJ0uTtz0OjT+p7CYa6riTk9BfDGeD06HO=dXAH_7B0wg@mail.gmail.com>
Date: Tue, 3 Feb 2026 16:27:09 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: move tcp_rbtree_insert() to tcp_output.c

On Mon, Feb 2, 2026 at 8:51 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> tcp_rbtree_insert() is primarily used from tcp_output.c
> In tcp_input.c, only (slow path) tcp_collapse() uses it.
>
> Move it to tcp_output.c to allow its (auto)inlining to improve
> TCP tx fast path.
>
> $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new
> add/remove: 0/0 grow/shrink: 4/1 up/down: 445/-115 (330)
> Function                                     old     new   delta
> tcp_connect                                 4277    4478    +201
> tcp_event_new_data_sent                      162     248     +86
> tcp_send_synack                              780     862     +82
> tcp_fragment                                1185    1261     +76
> tcp_collapse                                1524    1409    -115
> Total: Before=24896043, After=24896373, chg +0.00%
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>