netdev - [PATCH net-next 1/2] net: ti: icssg-prueth-sr1: Remove unused workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260204-icssg-prueth-workqueue-v1-1-9a892f4b293d@gmail.com>
Date: Wed, 04 Feb 2026 10:41:10 +0800
From: Kevin Hao <haokexin@...il.com>
To: netdev@...r.kernel.org
Cc: MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
 Meghana Malladi <m-malladi@...com>, Jacob Keller <jacob.e.keller@...el.com>, 
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
 Himanshu Mittal <h-mittal1@...com>, Simon Horman <horms@...nel.org>, 
 Byungchul Park <byungchul@...com>, 
 Markus Elfring <elfring@...rs.sourceforge.net>, 
 Kevin Hao <haokexin@...il.com>
Subject: [PATCH net-next 1/2] net: ti: icssg-prueth-sr1: Remove unused
 workqueue

The dedicated workqueue emac->cmd_wq is not utilized in this driver and
can be safely removed.

Signed-off-by: Kevin Hao <haokexin@...il.com>
---
 drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
index 7bb4f0d850cc72d997e5ead38cf56f1dbc2355a1..b8115ca47082f9676067bb65c6eb3a441290fd7c 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
@@ -783,11 +783,6 @@ static int prueth_netdev_init(struct prueth *prueth,
 	emac->prueth = prueth;
 	emac->ndev = ndev;
 	emac->port_id = port;
-	emac->cmd_wq = create_singlethread_workqueue("icssg_cmd_wq");
-	if (!emac->cmd_wq) {
-		ret = -ENOMEM;
-		goto free_ndev;
-	}

 	INIT_DELAYED_WORK(&emac->stats_work, icssg_stats_work_handler);

@@ -798,7 +793,7 @@ static int prueth_netdev_init(struct prueth *prueth,
 	if (ret) {
 		dev_err(prueth->dev, "unable to get DRAM: %d\n", ret);
 		ret = -ENOMEM;
-		goto free_wq;
+		goto free_ndev;
 	}

 	/* SR1.0 uses a dedicated high priority channel
@@ -883,8 +878,6 @@ static int prueth_netdev_init(struct prueth *prueth,

 free:
 	pruss_release_mem_region(prueth->pruss, &emac->dram);
-free_wq:
-	destroy_workqueue(emac->cmd_wq);
 free_ndev:
 	emac->ndev = NULL;
 	prueth->emac[mac] = NULL;

-- 
2.52.0