netdev - RE: RE: [Intel-wired-lan] [PATCH iwl-next v3] igb: Retrieve Tx timestamp directly from interrupt for i210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89865B46DCBEB496BE28703BE599A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 5 Feb 2026 10:37:05 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC: Kurt Kanzenbach <kurt@...utronix.de>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Paul Menzel <pmenzel@...gen.mpg.de>, "Vadim
 Fedorenko" <vadim.fedorenko@...ux.dev>, "Gomes, Vinicius"
	<vinicius.gomes@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Richard Cochran <richardcochran@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, Eric Dumazet <edumazet@...gle.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller"
	<davem@...emloft.net>
Subject: RE: RE: [Intel-wired-lan] [PATCH iwl-next v3] igb: Retrieve Tx
 timestamp directly from interrupt for i210



> -----Original Message-----
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Sent: Thursday, February 5, 2026 11:04 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> Cc: Kurt Kanzenbach <kurt@...utronix.de>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Paul Menzel <pmenzel@...gen.mpg.de>;
> Vadim Fedorenko <vadim.fedorenko@...ux.dev>; Gomes, Vinicius
> <vinicius.gomes@...el.com>; netdev@...r.kernel.org; Richard Cochran
> <richardcochran@...il.com>; linux-kernel@...r.kernel.org; Andrew Lunn
> <andrew+netdev@...n.ch>; Eric Dumazet <edumazet@...gle.com>; intel-
> wired-lan@...ts.osuosl.org; Keller, Jacob E
> <jacob.e.keller@...el.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>
> Subject: Re: RE: [Intel-wired-lan] [PATCH iwl-next v3] igb: Retrieve
> Tx timestamp directly from interrupt for i210
> 
> On 2026-02-05 09:47:14 [+0000], Loktionov, Aleksandr wrote:
> …
> > > --- a/drivers/net/ethernet/intel/igb/igb_ptp.c
> > > +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c
> > > @@ -796,6 +796,28 @@ static int igb_ptp_verify_pin(struct
> …
> > > +	igb_ptp_tx_hwtstamp(adapter); <-Calls existing function
> designed for work queue!
> >
> > skb_tstamp_tx() can sleep
> > Smells like sleep-in-atomic isn't it?
> 
> How or where can it sleep?
> 
> Sebastian

igb_ptp_tx_hwtstamp() -> https://elixir.bootlin.com/linux/v6.19-rc5/C/ident/skb_tstamp_tx -> https://elixir.bootlin.com/linux/v6.19-rc5/C/ident/__skb_complete_tx_timestamp -> https://elixir.bootlin.com/linux/v6.19-rc5/C/ident/sock_queue_err_skb -> https://elixir.bootlin.com/linux/v6.19-rc5/C/ident/skb_queue_tail -> https://elixir.bootlin.com/linux/v6.19-rc5/source/net/core/skbuff.c#L4075 

spin_lock_irqsave(&wq_head->lock, flags);  <- RT mutex can sleep