netdev - RE: [EXTERNAL] [PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BN9PR18MB425184A7FABBF691E4C99DAFDB99A@BN9PR18MB4251.namprd18.prod.outlook.com>
Date: Thu, 5 Feb 2026 10:49:49 +0000
From: Elad Nachman <enachman@...vell.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>,
        "Taras Chornyi [C]"
	<tchornyi@...vell.com>,
        "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>,
        "Vadym
 Kochan [C]" <vkochan@...vell.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "alok.a.tiwarilinux@...il.com" <alok.a.tiwarilinux@...il.com>
Subject: RE: [EXTERNAL] [PATCH v2 net-next] net: marvell: prestera: fix FEC
 error message for SFP ports

> 
> 
> From: Alok Tiwari <alok.a.tiwari@...cle.com>
> Sent: Thursday, February 5, 2026 11:20 AM
> To: Elad Nachman <enachman@...vell.com>; Taras Chornyi [C] <tchornyi@...vell.com>; Volodymyr Mytnyk [C] <vmytnyk@...vell.com>; Vadym Kochan [C] <vkochan@...vell.com>; pabeni@...hat.com; kuba@...nel.org; edumazet@...gle.com; davem@...emloft.net; andrew+netdev@...n.ch; netdev@...r.kernel.org
> Cc: alok.a.tiwarilinux@...il.com; alok.a.tiwari@...cle.com
> Subject: [EXTERNAL] [PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports
> 
> In prestera_ethtool_set_fecparam(), the error message is opposite of
> the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is
> not allowed on SFP ports, but the message says "non-SFP ports", which
> does not match the condition. However, FEC may be required depending on
> the transceiver, cable, or mode, and firmware already validates invalid
> combinations.
> 
> Remove the SFP transceiver check and let firmware handle validation.
> 
> Signed-off-by: Alok Tiwari <mailto:alok.a.tiwari@...cle.com>
> ---
> v1 -> v2
> remove condition of if (port->caps.transceiver ==
> PRESTERA_PORT_TCVR_SFP)  check instead of error message correction
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_ethtool.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> index 2f52daba58e6..750c72f628e5 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> @@ -717,11 +717,6 @@ static int prestera_ethtool_set_fecparam(struct net_device *dev,
>  		return -EINVAL;
>  	}
> 
> -	if (port->caps.transceiver == PRESTERA_PORT_TCVR_SFP) {
> -		netdev_err(dev, "FEC set is not allowed on non-SFP ports\n");
> -		return -EINVAL;
> -	}
> -
>  	fec = PRESTERA_PORT_FEC_MAX;
>  	for (mode = 0; mode < PRESTERA_PORT_FEC_MAX; mode++) {
>  		if ((port_fec_caps[mode].eth_fec & fecparam->fec) &&
> --
> 2.50.1
>

Acked-by: Elad Nachman <enachman@...vell.com>